Use eth-utils methods instead of custom web3 methods

[kclowes]

What was wrong?

There were a couple duplicate functions in both eth-utils and web3. We want to standardize on eth-utils.

Related to Issue #1197

How was it fixed?

Took out the duplicate methods from web3, and added a note to the v6 breaking changes for apply_formatters_to_array which is very close but not quite the same between the two libraries.

Todo:

• Add entry to the release notes

Cute Animal Picture

[pipermerriam]

Since apply_formatters_to_array is under the web3._utils namespace we don't have to maintain backwards compatibility since it's considered a private API (so no need to wait till v6 nor is there need to make the existing formatters importable from web3._utils.formatters

[kclowes]

@pipermerriam I think it is a breaking change because we use it in middleware? The web3 apply_formatters_to_array converts the result to a list, but the eth-utils version does not. Because we use the web3 apply_formatters_to_array in the pythonic formatting middleware, a bunch of the ENS tests started failing because they were expecting a list to be returned from w3.eth.accounts, but got a tuple instead. I suspect others may run into the same problem. Maybe it's better to use the eth-utils apply_formatters_to_array and convert to a list on the web3 side?

[pipermerriam]

Maybe it's better to use the eth-utils apply_formatters_to_array and convert to a list on the web3 side?

That is what I would advocate for (and ideally leave a note to do any cleanup in v6 if you think it's worth removing the shim then)