Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quickest infura instructions #1482

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Conversation

cupOJoseph
Copy link
Contributor

@cupOJoseph cupOJoseph commented Oct 28, 2019

What was wrong?

The quick start was not quick enough. Several python developers I recommended it to were stuck on connecting a node. The quick start example required users to look through docs elsewhere (bad user experience, most will quit at this step) in order to connect to a provider.

Related to Issue #1481

How was it fixed?

Added explanation of Infura and setting Infura global variable to quick start docs.

Todo:

Cute Animal Picture (my puppy Stella)

1021191535_HDR

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jschiarizzi! @pipermerriam any feedback here?

docs/quickstart.rst Outdated Show resolved Hide resolved
docs/quickstart.rst Show resolved Hide resolved
@cupOJoseph
Copy link
Contributor Author

oof now i'm failing a check... Let's see if I can fix it not.

@cupOJoseph
Copy link
Contributor Author

Great, looks like the checks are passing now. I never made a .rst file before so that syntax took a hot minute to figure out. :) Should be good for a merge now @kclowes


This ``w3`` instance will now allow you to interact with the Ethereum
blockchain.

.. NOTE::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any objections to the updated wording @jschiarizzi?

@kclowes
Copy link
Collaborator

kclowes commented Nov 7, 2019

Thanks @jschiarizzi! Feel free to open another PR if you don't like my updates :)

@kclowes kclowes merged commit c4b2493 into ethereum:master Nov 7, 2019
@cupOJoseph
Copy link
Contributor Author

Looking good, thanks. Sorry I didn't comment, busy week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants