Add type hints to web3.main #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
type-hints-main
branch
from
d993ac2
to
f4ea824
Compare
njgheorghita
commented
Nov 1, 2019
web3/main.py
Outdated
| return self.codec.is_encodable(_type, value) | ||
|
|
||
| @property | ||
| def ens(self): | ||
| def ens(self) -> Union[ENS, Empty]: |
There was a problem hiding this comment.
I'm not sure if there's a better way to handle this, since it should always be returning only ENS - but since web3.ens is set to a default Empty type in the constructor args, this seems like the only way to make mypy happy.
There was a problem hiding this comment.
I think you could fix this using a cast right?
njgheorghita
force-pushed
the
type-hints-main
branch
from
f4ea824
to
1d2797d
Compare
njgheorghita
force-pushed
the
type-hints-main
branch
from
1d2797d
to
1068f8e
Compare
pipermerriam
approved these changes
Nov 1, 2019
web3/main.py
Outdated
| return self.codec.is_encodable(_type, value) | ||
|
|
||
| @property | ||
| def ens(self): | ||
| def ens(self) -> Union[ENS, Empty]: |
There was a problem hiding this comment.
I think you could fix this using a cast right?
web3/main.py
Outdated
| def __init__( | ||
| self, | ||
| provider: BaseProvider=None, | ||
| middlewares: List[Any]=None, |
There was a problem hiding this comment.
This should probably be Sequence
web3/main.py
Outdated
| self, | ||
| provider: BaseProvider=None, | ||
| middlewares: List[Any]=None, | ||
| modules: Dict[str, Iterable[Any]]=None, |
There was a problem hiding this comment.
This should probably be Sequence[Any].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Start adding mypy type hints to
web3- starting withweb3.main.Todo:
Cute Animal Picture