Add __str__ for IPCProvider #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
previously approved these changes
Dec 4, 2019
|
@nfeignon FYI your failing lint test should pass now if you rebase off master, or update |
|
Blerg, lint errors. @njgheorghita do you know why those lint errors are popping up? I rebased off of master, and looks like eth-utils is at 1.8.4 🤔 |
Co-Authored-By: Piper Merriam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
IPCProvider is missing a string representation. RPC and websocket providers both have one.
How was it fixed?
Add __str__() method to IPCProvider.
Cute Animal Picture