Solidity receive #1623
Merged
Solidity receive #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
solidity-receive
branch
from
fe1063f
to
0a00fd9
Compare
kclowes
force-pushed
the
solidity-receive
branch
from
0a00fd9
to
e9c4a9f
Compare
…readthedocs.io/en/v0.6.1/060-breaking-changes.html#semantic-and-syntactic-changes ), without which ^0.6.0 contracts with receive payable fallback function would fail web3.py for _any_ function call due to missing "name" key in abi (there should probably be another few places that "receive" needs to be added next to "fallback", this is just a starting point that fixed my immediate problem at hand
kclowes
force-pushed
the
solidity-receive
branch
from
e939c48
to
319e629
Compare
pipermerriam
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
web3 didn't support Solidity's new
receivekeyword.Broken docs build has been fixed in #1622
Related to Issue #1565, #1566
How was it fixed?
Added a new contract API:
contract.receive, that basically mirrors the fallback function.Todo:
Cute Animal Picture