Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPCProvider argument type bug #1647

Closed
carver opened this issue May 13, 2020 · 0 comments · Fixed by #1653
Closed

IPCProvider argument type bug #1647

carver opened this issue May 13, 2020 · 0 comments · Fixed by #1653
Labels
Good First Issue

Comments

@carver
Copy link
Collaborator

carver commented May 13, 2020

What was wrong?

IPCProvider correctly handles a pathlib.Path as its ipc_path argument, but the type annotation says it only accepts str.

How can it be fixed?

Change it to Union[str, Path]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

permit pathlib.Path type as IPCProvider input wolovim/web3.py
2 participants
@carver @wolovim