Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Flake8 #1720

Closed
kclowes opened this issue Aug 27, 2020 · 2 comments
Closed

Update Flake8 #1720

kclowes opened this issue Aug 27, 2020 · 2 comments
Labels
Good First Issue

Comments

@kclowes
Copy link
Collaborator

kclowes commented Aug 27, 2020

  • Version: 5.12.0
  • Python: 3.8

What was wrong?

flake8 3.4.1 doesn't run with python 3.8, but upgrading flake8 will fail our linting.

How can it be fixed?

Upgrade flake8 to the most recent version and fix all the errors.

...Or maybe this is a good time to pull in black
@pratik-vii
Copy link
Contributor

@kclowes I will pick this up. please assign to me.

@pratik-vii pratik-vii mentioned this issue Oct 2, 2020
Merged
@kclowes
Copy link
Collaborator Author

kclowes commented Oct 28, 2020

Closed via #1759.

@kclowes kclowes closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kclowes @pratik-vii