Eth -> Method getBlock #1735
Merged
Eth -> Method getBlock #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
eth-to-method-3
branch
2 times, most recently
from
90bde3c
to
b6b3393
Compare
|
I think the ethpm tests are failing because IPFS is having trouble today 🤷 I'll make sure they're passing before merging. |
Raise BlockNotFound on null response, no error msg Pass params to null result formatters
kclowes
force-pushed
the
eth-to-method-3
branch
from
d62eb2d
to
f780dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The Eth module needs to be moved to use Method. Part 3 includes changes to eth_getBlock
Related to Issue #1568
How was it fixed?
Updated eth.py to use Method for getBlock.
Todo:
Cute Animal Picture