Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getFilterChanges, getFilterLogs, and getLogs use Method #1752

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Sep 25, 2020

What was wrong?

eth_getFilterChanges, getFilterLogs, and getLogs now use Method.

I removed a test file because there's another one that's both more realistic and tests the same thing in the integration tests:

filter_params = {
"fromBlock": BlockNumber(0),
"address": UNKNOWN_ADDRESS,
}
result = web3.eth.getLogs(filter_params)
assert len(result) == 0

Related to Issue #1568

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes changed the title [WIP] eth_getFilterChanges, getFilterLogs, and getLogs use Method eth_getFilterChanges, getFilterLogs, and getLogs use Method Sep 25, 2020
ABI_REQUEST_FORMATTERS,
PYTHONIC_REQUEST_FORMATTERS,
METHOD_NORMALIZERS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

channeling an old review: if this order is important, might be worth documenting with a comment explanation.

@kclowes kclowes merged commit a7ed907 into ethereum:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants