-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update method_formatters.py #1757
Update method_formatters.py #1757
Conversation
So, it looks to me like Infura recently updated the version of their IPFS endpoint to Lmk what you think the best way to proceed is, as I see it we have a couple of options.
|
4457072
to
b2e8657
Compare
@njgheorghita Okay, I see. Thank you for explaining that. Those sound like decent options that we can consider. @pipermerriam @kclowes Of these options, which do you think would be the best for us to proceed with? |
@njgheorghita pointed out a fix PR waiting for review, but it's not a very active repo. I'm not opposed to just xfail these tests for now, but is that doable for doctests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as long as the tests pass after you merge in master!
b2e8657
to
52cec1c
Compare
@tmckenzie51 You can try and push an empty commit to see if that readthedocs failure will work itself out: |
removes duplicate block_number_formatter method in favor of to_hex_if_integer method.
adds release notes
52cec1c
to
3332989
Compare
removes duplicate block_number_formatter method in favor of to_hex_if_integer method.
What was wrong?
The methods block_number_formatter and to_hex_if_integer were duplicate functionality.
Related to Issue #1745
How was it fixed?
block_number_formatter method was replaced with the to_hex_if_integer method.
Todo:
Cute Animal Picture