Mark failing tests as such until ipfshttpclient is updated #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
changed the title
kclowes
changed the title
kclowes
force-pushed
the
ipfs-failures
branch
2 times, most recently
from
616695b
to
8703160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Infura's IPFS gateway updated to go-ipfs v0.7.0 which
ipfshttpclientdoesn't support, so all of our IPFS tests that use the Infura backend are broken.Related to Issue #1757
How was it fixed?
See comment here for a better description of the problem. If
ipfshttpclientdoesn't update soon (PR up here), it may be worth pursuing one of the more long-term solutions, but we can decide that in a few weeks. For now, this unblocks a bunch of PRs that need to be merged.Todo:
Cute Animal Picture