Remove setuptools-markdown requirement #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as this is now built-in
|
(I'll add entry to the release notes once I know that you are ok to merge) |
|
This seems incomplete. Check out our project template here for an example: Needs a |
|
Based on that blog post, it also looks like we'll need to upgrade our |
|
Sorry I thought it would be too easy :) Now reads the description from Readme.md pursuant to example and bumps setuptools. Also added newsfragment. |
|
Thanks! Any idea when the next release will be? |
|
I may be able to get to one today, otherwise I'll plan on Monday. |
|
ok cool |
|
@step21 done! 5.12.3 is out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as this is now built-in
What was wrong?
setuptools-markdown creates a huge dependency on pandoc and subsequently ghc, but is probably no longer necessary as this is now built in.
Related to Issue #306
How was it fixed?
Pursuant to https://dustingram.com/articles/2018/03/16/markdown-descriptions-on-pypi/ it is now built-in and in fact this format is already used in web3.py
Todo:
Cute Animal Picture