tests return values against different geth versions #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmckenzie51
force-pushed
the
tiffany/geth-versions
branch
from
f2c6775
to
187b564
Compare
kclowes
approved these changes
Nov 11, 2020
tmckenzie51
force-pushed
the
tiffany/geth-versions
branch
from
6f37e2c
to
b96bf5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1572
How was it fixed?
In order to be compatible with the most recent geth versions v 1.9.19+, test_eth_getBlockByNumber was modified to ensure that a block number is being returned, rather than null. Also, a test for getBlockByHash for pending blocks was added.
Todo:
Cute Animal Picture