Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize apply_formatter_to_array #1902

Closed
kclowes opened this issue Mar 11, 2021 · 1 comment · Fixed by #2737
Closed

Standardize apply_formatter_to_array #1902

kclowes opened this issue Mar 11, 2021 · 1 comment · Fixed by #2737

Comments

@kclowes
Copy link
Collaborator

kclowes commented Mar 11, 2021

  • Version: v6

What was wrong?

The eth-utils and web3 apply_formatter_to_array functions are slightly different. We should standardize on one or the other (probably the eth-utils version). The apply_formatter_to_array function in web3 converts the return value to an array and the eth-utils version does not.
@kclowes kclowes mentioned this issue Mar 11, 2021
Closed
22 tasks
@dbfreem
Copy link
Contributor

dbfreem commented Apr 25, 2022

if the desire is to standardize on one should we just remove apply_formatter_to_array from web3 and utilize the one from eth-utils?

@fselmo fselmo mentioned this issue Nov 23, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove internal apply_formatters_to_array fselmo/web3.py
2 participants
@kclowes @dbfreem