Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing.rst #1909

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Update contributing.rst #1909

merged 2 commits into from
Mar 18, 2021

Conversation

miohtama
Copy link
Contributor

Doc update: In some shells (zsh), [] are reserved characters, so we need to escape them. The old example only works in Bash.

Cute Animal Picture

\|/          (__)    
     `\------(oo)
       ||    (__)
       ||w--||     \|/
   \|/

wolovim
wolovim approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@wolovim wolovim closed this Mar 18, 2021
@wolovim wolovim reopened this Mar 18, 2021
miohtama and others added 2 commits March 18, 2021 13:00
@miohtama @wolovim
Update contributing.rst
e5f6fd1 
In some shells (zsh), `[]` are reserved characters, so we need to escape them. The old example only works in Bash.
@wolovim
add newsfragment
0e36cbf
@wolovim wolovim merged commit c02b0fb into ethereum:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolovim wolovim wolovim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miohtama @wolovim