Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate estimateGas in favor of estimate_gas #1913

Merged

Conversation

tmckenzie51
Copy link
Contributor

@tmckenzie51 tmckenzie51 commented Mar 15, 2021

What was wrong?

Added estimate_gas, deprecated estimateGas

Related to Issue #1429

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@tmckenzie51 tmckenzie51 force-pushed the tiffany/estimateGas-to-snakecase branch from 3ebe347 to c05297c Compare March 24, 2021 15:58
@tmckenzie51 tmckenzie51 changed the title snakecase EstimateGas to estimate_gas deprecate estimateGas in favor of estimate_gas Mar 25, 2021
@tmckenzie51 tmckenzie51 force-pushed the tiffany/estimateGas-to-snakecase branch from 304835e to e0d07c6 Compare March 25, 2021 19:39
@tmckenzie51 tmckenzie51 force-pushed the tiffany/estimateGas-to-snakecase branch from fadd5d8 to c31dbdc Compare March 26, 2021 19:59
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed an estimateGas in web3/contract.py on line 642, and line 1618. Manual testing looks good!

docs/examples.rst Outdated Show resolved Hide resolved
docs/web3.eth.rst Outdated Show resolved Hide resolved
docs/contracts.rst Outdated Show resolved Hide resolved
docs/web3.eth.rst Outdated Show resolved Hide resolved
docs/web3.eth.rst Outdated Show resolved Hide resolved
@kclowes kclowes force-pushed the tiffany/estimateGas-to-snakecase branch from 7056d1b to 750ace4 Compare April 5, 2021 20:32
@kclowes kclowes force-pushed the tiffany/estimateGas-to-snakecase branch from 750ace4 to b195cf9 Compare April 5, 2021 20:43
@kclowes kclowes merged commit 2e81408 into ethereum:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants