Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace_block, deprecate traceBlock #1961

Merged

Conversation

tmckenzie51
Copy link
Contributor

@tmckenzie51 tmckenzie51 commented Apr 26, 2021

What was wrong?

add trace_block, deprecate traceBlock

Related to Issue #1429

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment on this one as the last one: We'll want to mark the old trace_block tests as xfailing in tests/integration/parity/common.py. Looks good other than that!

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥! 👍

@tmckenzie51 tmckenzie51 merged commit e8bb5e6 into ethereum:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants