Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Explicitly note solidityKeccak performs a packed encoding. #1971

Merged
merged 2 commits into from
May 5, 2021

Conversation

gnattishness
Copy link
Contributor

What was wrong?

The docs diddn't explicitly state what type of encoding web3.solidityKeccak performs.
As of Solidity v0.5.x, keccak256 doesn't do any automatic encoding.
People less familiar with Solidity v0.4.x could find the description ambiguous.

How was it fixed?

Added to relevant docs section.

I also thought it'd be nice to add examples of the equivalent solidity (which should be valid for v0.5.x - v0.8.x at least)


Thanks! Let me know if there's any quibbles or things I can adjust.

Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional context! I'll add a newsfragment and any other wordsmithing, then merge it in.

@wolovim wolovim merged commit f143b0e into ethereum:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants