Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both 0.7.0 and 0.7.0a1 for ipfshttpclient #1993

Merged
merged 1 commit into from
May 14, 2021

Conversation

brunneis
Copy link
Contributor

What was wrong?

The ipfshttpclient version was fixed to 0.7.0a1. However, 0.7.0 was released already with "No changes compared to 0.7.0a1" (https://github.com/ipfs-shipyard/py-ipfs-http-client/blob/master/CHANGELOG.md).

py-ipfs-http-client 0.7.0 (15.03.2021)

  • No changes compared to 0.7.0a1 – breaking changes delayed to the unknown future

Since the version is fixed, web3.py cannot be installed when ipfshttpclient==0.7.0 is installed.

How was it fixed?

Under setup.py, install_requires was updated so both versions are supported.

@kclowes
Copy link
Collaborator

kclowes commented May 14, 2021

Thanks for the contribution @brunneis! Since there aren't any changes between 0.7.0a1 and 0.7.0, let's just specify 0.7.0. I'll update and merge!

@kclowes kclowes merged commit 6dbd66d into ethereum:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants