Async net module #2044
Merged
Async net module #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
commented
Jun 30, 2021
kclowes
force-pushed
the
async-net
branch
2 times, most recently
from
f16315a
to
ef03d9d
Compare
|
This is ready for a look when you get a chance @fselmo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Name to address middleware uses
w3.net.versionto check that the user is attached to mainnet before resolving an ENS name, but there is no async net module yet. This PR adds it.Related to Issue #1990
How was it fixed?
Added a
BaseNet, and anAsyncNetclass, along with some tests.Todo:
Cute Animal Picture