Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that using block_identifier with .call() comes with its caveats #2048

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

miohtama
Copy link
Contributor

To manage the expectations of the client library users.

What was wrong?

Programmers were using call with a block number, but did not know it might not work as it.

How was it fixed?

Document block_identifier behavior with various Ethereum nodes.

Cute Animal Picture

-=[ bull ]=-  12/96

   ,/         \,
  ((__,-"""-,__))
   `--)~   ~(--`
  .-'(       )`-,
  `~~`d\   /b`~~`
      |     |
 jgs  (6___6)
       `---`

…eats

To manage the expectations of the client library users.
@miohtama
Copy link
Contributor Author

Looks like the docs fails in Circle CI, but when I click "Details" it asks me for a login. Are the CI reports publicly available?

@kclowes
Copy link
Collaborator

kclowes commented Jun 23, 2021

Thanks for the clarification @miohtama! You should definitely be able to see the CI from a branch you wrote but you may need to log in to CircleCI with your Github creds. But to fix the docs build, you just need to unindent the paragraph you wrote. The geth failure is a flaky failure.

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kclowes kclowes merged commit b396144 into ethereum:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants