Fix tests from 1835 changes and default to 1559 fields for testing #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
1835-fix-tests-and-default-to-1559-fields
branch
9 times, most recently
from
5af1986
to
44a93ac
Compare
fselmo
changed the title
fselmo
force-pushed
the
1835-fix-tests-and-default-to-1559-fields
branch
2 times, most recently
from
1277e66
to
f1b4040
Compare
fselmo
force-pushed
the
1835-fix-tests-and-default-to-1559-fields
branch
2 times, most recently
from
9e4149a
to
ca957fb
Compare
kclowes
approved these changes
Jun 30, 2021
| try: | ||
| web3.geth.miner.start() | ||
| super().test_eth_replace_transaction_already_mined(web3, unlocked_account_dual_type) | ||
| finally: |
| @pytest.mark.skip(reason="London TODO: crashes on [address_conversion_func1]") | ||
| @pytest.mark.xfail( | ||
| strict=False, | ||
| reason='Sometimes a TimeoutError is hit when waiting for the txn to be mined', |
There was a problem hiding this comment.
If this consistently fails on one error type, we should add the raises line back in so that we know it's flaky in the way we think it's flaky
fselmo
force-pushed
the
1835-fix-tests-and-default-to-1559-fields
branch
from
ca957fb
to
1c178cd
Compare
…debugging / curiosity
- Fixed tests that were failing from the implementation of the new EIP-1559 fields (maxFeePerGas and maxPriorityFeePerGas). Updated most of our existing tests to use these new fields in order to encourage their use / be updated to the new standard. - Updated documentation around unit and integration testing and how to contribute to our test suite.
fselmo
force-pushed
the
1835-fix-tests-and-default-to-1559-fields
branch
from
1c178cd
to
5e011f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1835
How was it fixed?
Some older tests seemed to be breaking others because they did not meet updated requirements to be included in a pending block, seemingly creating a txn jam. Increasing
gasPricefor these tests seemed to move things along. Another issue we have is that some tests have their context dirtied by other tests. I included a way to move some tests to the beginning of the test suite to prevent this dirtied context and allow these tests to pass.Updated default tests to use the new 1559 fields for our transactions.
Todo:
maxFeePerGasandmaxPriorityFeePerGasovergasPriceas defaultsCute Animal Picture