Update documentation #2058
Merged
Update documentation #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace_transaction() and modify_transaction() were listed as returning strings, when in fact they return HexBytes.
kclowes
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Thanks @schwartzman! Sorry it took me so long to get to this. I made a few nitpicky changes, and will add a newsfragment and merge!
kclowes
added a commit
to Moras-del/web3.py
that referenced
this pull request
Jul 14, 2021
replace_transaction() and modify_transaction() were listed as returning strings, when in fact they return HexBytes. * Added a full tx hash, and added arguments back to modify_tx docs Co-authored-by: kclowes <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
replace_transaction() and modify_transaction() were listed as returning strings, when in fact they return HexBytes.
How was it fixed?
Updated documentation
Cute Animal Picture