Update eth-account version & add eip-1559 eth_signTransaction support #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
eip-1559-sign-transaction-support
branch
4 times, most recently
from
e20b1f5
to
8a0eee4
Compare
Updated the eth-account version to the latest which includes eip-1559 support. Added integration tests and made minor tweaks to support eip-1559 params for eth_signTransaction
fselmo
force-pushed
the
eip-1559-sign-transaction-support
branch
from
8a0eee4
to
cea04e9
Compare
fselmo
force-pushed
the
eip-1559-sign-transaction-support
branch
from
95cee49
to
e4aff8a
Compare
|
Thank you; this works nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the eth-account version to the latest which includes eip-1559 support. Added integration tests and made minor tweaks to support eip-1559 params for eth_signTransaction
What was wrong?
maxFeePerGasandmaxPriorityFeePerGasforeth_signTransactionandeth-accounthad not added support for eip-1559 in general. Once both of these added support for the new params, we needed to update the method formatters to support these fields foreth_signTransactionRelated to Issue #2065
How was it fixed?
maxFeePerGasandmaxPriorityFeePerGasTodo:
Cute Animal Picture