Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async eth_call #2083

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Async eth_call #2083

merged 2 commits into from
Jul 23, 2021

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jul 22, 2021 •
edited
Loading

What was wrong?

Name to address middleware uses eth_call along the way, so added eth_call to the growing list of async eth methods.

Related to Issue #1990

How was it fixed?

Added async eth_call. Also updated docs to reflect available async methods and middleware.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes changed the title [WIP] Async eth_call Async eth_call Jul 23, 2021
@kclowes kclowes requested a review from fselmo July 23, 2021 17:08
fselmo
fselmo approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

@kclowes kclowes merged commit 8586a00 into ethereum:master Jul 23, 2021
@kclowes kclowes deleted the async-eth-call branch July 23, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kclowes @fselmo