Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async support for formatting, validation, and geth poa middlewares #2098

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Aug 6, 2021

What was wrong?

How was it fixed?

  • Async support added to:
    • formatting middleware
    • validation middleware
    • geth poa middleware

Todo:

  • Refactored code to extract the chainId earlier in the validation process so we do not have to create async methods for every step of the way before the actual web3 call
  • Added async support but due to the nature of the validation + formatting middleware relationship (functools) this is not in an ideal state. Ideally we can provide it in the same manner as the middlewares with current async support
  • Due to explanation in previous bullet, possibly refactor the code so there is no need to await the middleware as it is being passed into the Web3 intance
  • Add entry to the release notes

Cute Animal Picture

20220202_120437

@fselmo fselmo force-pushed the async-validation-middleware branch 5 times, most recently from 601198d to 28c05a0 Compare August 8, 2021 19:57
@fselmo fselmo force-pushed the async-validation-middleware branch 2 times, most recently from 2c53132 to 9138ed5 Compare November 18, 2021 18:12
@fselmo fselmo force-pushed the async-validation-middleware branch 2 times, most recently from 53f1de3 to ab0e765 Compare December 15, 2021 20:31
@fselmo fselmo force-pushed the async-validation-middleware branch from ab0e765 to 57135ba Compare February 3, 2022 23:23
@fselmo fselmo changed the title [WIP] formatting and validation middleware async support async support for formatting, validation, and geth poa middlewares Feb 4, 2022
@fselmo fselmo force-pushed the async-validation-middleware branch from 57135ba to dffd6e4 Compare February 4, 2022 00:10
@fselmo fselmo force-pushed the async-validation-middleware branch from dffd6e4 to 4c46b2f Compare February 4, 2022 17:37
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 🚢 ⛵ 🛥️

@fselmo fselmo merged commit 36adb16 into ethereum:master Feb 4, 2022
@fselmo fselmo deleted the async-validation-middleware branch February 4, 2022 17:51
@DefiDebauchery
Copy link
Contributor

Epic. Thank you so much for picking up my mess!

@fselmo
Copy link
Collaborator Author

fselmo commented Feb 4, 2022

Epic. Thank you so much for picking up my mess!

Not at all... thanks for giving this some eyes. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants