Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AsyncHTTPProvider docs #2123

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Aug 27, 2021

What was wrong?

The AsyncHTTPProvider docs were unclear and causing confusion.

Closes #2121

How was it fixed?

Added the modules and middlewares args

Todo:

Cute Animal Picture

image

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kclowes kclowes merged commit 0265cba into ethereum:master Aug 27, 2021
@kclowes kclowes deleted the update-async-provider-docs branch August 27, 2021 17:42
@helgridly
Copy link
Contributor

typo:

modules={'eth', (AsyncEth,), 'net': (AsyncNet,)},

should be

modules={'eth': (AsyncEth,), 'net': (AsyncNet,)},

i.e. colon instead of comma between eth and AsyncEth

@kclowes
Copy link
Collaborator Author

kclowes commented Sep 3, 2021

oops, thanks @helgridly! Feel free to submit a PR if you have time, otherwise I'll fix it soon!

@ak8g18
Copy link

ak8g18 commented Oct 10, 2022

Hey, I wanted to know what other modules we can use for AsyncHTTPProvider. I want to use the async library to make smart contract calls i.e web3.contract.functions... . I tried passing in: modules = modules={'eth', (AsyncEth,), 'contract': (AsyncContract,)}, but this hasn't worked. Kindly help with this

@jdbertron
Copy link

I have the exact same same issue as @ak8g18 above.

@kclowes
Copy link
Collaborator Author

kclowes commented Feb 1, 2023

Async Contract should be working as of v6b3, so make sure you're using that version or higher. If you're still having trouble, it's best to open a new issue rather than commenting on old, closed ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue using AsyncHTTPProvider
5 participants