Raise BadResponseFormat if malformed JSON-RPC response #2188
+46
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When responses were coming back without a
result
key, a KeyError was thrown, which was not ideal.Related to Issue #2161
How was it fixed?
Now we raise a
BadResponseFormat
error with the raw response.BadResponseFormat
inherits from theKeyError
that was getting thrown for backwards compatibility.Todo:
Cute Animal Picture