Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy to 0.910 #2242

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Update mypy to 0.910 #2242

merged 1 commit into from
Dec 14, 2021

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Dec 9, 2021

What was wrong?

Somewhere along the way in a downstream library, the typing-extensions version requirement got updated.

How was it fixed?

mypy needs to be updated, along with the py-trie dependency in py-evm. The py-trie dependency has already been merged into py-evm. Once we release py-evm, we'll need to update eth-tester, and pull that in here. Then we can bump typing-extensions to v4+.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the update-mypy branch 5 times, most recently from 4fbd491 to 0f4ebba Compare December 13, 2021 20:51
@kclowes kclowes changed the title [WIP] Update mypy to 0.910 Update mypy to 0.910 Dec 13, 2021
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kclowes kclowes merged commit 869101e into ethereum:master Dec 14, 2021
@kclowes kclowes deleted the update-mypy branch December 14, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants