asyncify eth.mining #2252
Merged
asyncify eth.mining #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
asyncify_eth.mining
branch
from
bd1e3fe
to
ce1f4b0
Compare
pacrob
commented
Dec 14, 2021
|
|
||
| class AsyncEth(BaseEth): | ||
| is_async = True | ||
|
|
||
| @property |
There was a problem hiding this comment.
alphabetized and grouped properties at the top of the class
There was a problem hiding this comment.
Big fan of this re-org... properties before methods, etc... ty 👍
fselmo
approved these changes
Dec 15, 2021
|
|
||
| class AsyncEth(BaseEth): | ||
| is_async = True | ||
|
|
||
| @property |
There was a problem hiding this comment.
Big fan of this re-org... properties before methods, etc... ty 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Added async
eth.miningRelated to Issue #1413
How was it fixed?
Todo:
Cute Animal Picture
)