Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing import lines to async example #2302

Merged
merged 1 commit into from
Jan 13, 2022
Merged

add missing import lines to async example #2302

merged 1 commit into from
Jan 13, 2022

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Jan 13, 2022 •
edited
Loading

What was wrong?

AsyncHTTPProvider example used components without importing them

How was it fixed?

Added import lines

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

fselmo
fselmo approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@pacrob pacrob merged commit 0e6b54b into ethereum:master Jan 13, 2022
@pacrob pacrob deleted the fix_async_sample_imports branch January 13, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@wolovim wolovim Awaiting requested review from wolovim

@kclowes kclowes Awaiting requested review from kclowes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacrob @fselmo