move default_account and default_block to BaseEth #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
move_defaults_to_BaseEth
branch
2 times, most recently
from
ddac794
to
2bf8e58
Compare
pacrob
force-pushed
the
move_defaults_to_BaseEth
branch
from
2bf8e58
to
fac82ea
Compare
kclowes
approved these changes
Jan 20, 2022
pacrob
force-pushed
the
move_defaults_to_BaseEth
branch
from
fac82ea
to
1882d06
Compare
fselmo
reviewed
Jan 20, 2022
…Eth so Eth and AsyncEth can access
pacrob
force-pushed
the
move_defaults_to_BaseEth
branch
from
1882d06
to
d2c50a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
AsyncEth didn't have access to default_account or default_block properties and setters
How was it fixed?
I moved them to BaseEth
Todo:
Cute Animal Picture