correct misspellings and update referenced geth version #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
approved these changes
Jan 28, 2022
| @@ -309,7 +309,7 @@ The following methods are available on the ``web3.geth.personal`` namespace. | |||
|
|
|||
| Unlocks the given ``account`` for ``duration`` seconds. | |||
| If ``duration`` is ``None``, then the account will remain unlocked | |||
| for 300 seconds (which is current default by Geth v1.9.5); | |||
| for 300 seconds (which is current default by Geth v1.10.15); | |||
There was a problem hiding this comment.
Is 300 seconds for sure the current default?
There was a problem hiding this comment.
I did specifically verify that it's still 300 - https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Found misspellings in the
web3.gethdocs, fixed 'em, and updated current geth version while in there.Todo:
Cute Animal Picture