asyncify get_storage_at #2350
Merged
asyncify get_storage_at #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
reviewed
Feb 18, 2022
|
Thanks for the feedback @kclowes ! |
kclowes
approved these changes
Feb 23, 2022
Co-authored-by: kclowes <[email protected]>
kclowes
force-pushed
the
asyncify_eth.get_storage_at
branch
from
9b48f47
to
35f29be
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I needed this somewhat urgently for my project, so I've shamelessly copied PR #2331. Hope you guys don't mind...
Related to Issue #1413
How was it fixed?
I needed an async version of
get_storage_atfor my project. I read PR #2331 and it seemed fairly easy, so I just went ahead and implemented it.Todo:
Cute Animal Picture