Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary utf-8 encoding declarations #2353

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

wiseaidev
Copy link
Contributor

@wiseaidev wiseaidev commented Feb 18, 2022

What was wrong?

Related to Issue #

How was it fixed?

The line # -*- coding: utf-8 -*- is no longer required and Python >= 3.0 uses utf-8 encoding for source-code files by default.

Todo:

Cute Animal Picture

🐶

Signed-off-by: Harmouch101 <[email protected]>
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Harmouch101. Do you mind cherry-picking these commits onto the v5 branch as well and opening a new PR against the v5 branch? I'm happy to do it too if you don't have time!

@wiseaidev
Copy link
Contributor Author

Well, i'm currently AFK(writing this using the mobile app). So, you are good to do whatever you intend to. Not sure if the app is capable of doing so. Lemme check.

But either way, you've got super powers:

$ sudo chown -R ethereum:kclowes ${this(PR)}

@wiseaidev wiseaidev mentioned this pull request Feb 19, 2022
1 task
@wiseaidev
Copy link
Contributor Author

@kclowes, Done.

@kclowes kclowes changed the title 🧹 rm unnecessary utf-8 encoding declarations Remove unnecessary utf-8 encoding declarations Feb 23, 2022
@kclowes kclowes merged commit e36bffa into ethereum:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants