Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Update integration test fixture to use geth v1.10.17 #2454

Merged
merged 2 commits into from
May 2, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented May 2, 2022

  • Upgrade the go version used in the geth steps for circleci

py-geth 3.8.0 was released withs upport for geth v1.10.17. Would be good to test integration tests against this latest version of geth.

How was it fixed?

  • Use geth version 1.10.17 for integration test fixture
  • Update go version used in circleci geth steps to 1.18.1
  • Use pytest.mark.xfail with strict=False to get over the pesky timeout issues in some of our tests

Todo:

Cute Animal Picture

Monito del Monte:

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo force-pushed the v6-use-geth-fixture-1.10.17 branch from 86b9859 to 698965e Compare May 2, 2022 17:55
- Upgrade the go version used in the geth steps for circleci
@fselmo fselmo force-pushed the v6-use-geth-fixture-1.10.17 branch from 698965e to 76434d1 Compare May 2, 2022 18:04
@fselmo fselmo changed the title Update integration test fixture to use geth v1.10.17 [v6] Update integration test fixture to use geth v1.10.17 May 2, 2022
@fselmo fselmo requested a review from kclowes May 2, 2022 18:28
@fselmo fselmo force-pushed the v6-use-geth-fixture-1.10.17 branch from aa17edb to 8ff1dfe Compare May 2, 2022 18:32
- Added test_eth_get_transaction_receipt_unmined and test_eth_wait_for_transaction_receipt_unmined to the list of flaky tests with timeout issues.
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fselmo fselmo force-pushed the v6-use-geth-fixture-1.10.17 branch from 8ff1dfe to 69391b7 Compare May 2, 2022 18:50
@fselmo fselmo merged commit 595e55e into ethereum:master May 2, 2022
@fselmo fselmo deleted the v6-use-geth-fixture-1.10.17 branch June 8, 2022 21:21
@fselmo fselmo restored the v6-use-geth-fixture-1.10.17 branch June 8, 2022 21:21
@fselmo fselmo deleted the v6-use-geth-fixture-1.10.17 branch June 8, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants