Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black to web3/_utils/module_testing/ - Part 2 #2516

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jun 15, 2022

What was wrong?

Adding more black linting to web3/_utils. This branch was branched off of #2515, and should be merged after.

Related to Issue #1416

How was it fixed?

Consolidated black command in tox.ini to lint the whole of web3/_utils.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes changed the title Add black to web3/_utils/module_testing/ - Part II Add black to web3/_utils/module_testing/ - Part 2 Jun 16, 2022
@kclowes kclowes requested review from fselmo and pacrob June 16, 2022 19:43
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

We should add a45f6bdc04cd2339efb4cc204c56a6da69c021b4 to the .git-blame-ignore-revs file unless you plan on squashing. In which case, squash and add that to the file before merging?

@kclowes
Copy link
Collaborator Author

kclowes commented Jun 16, 2022

In which case, squash and add that to the file before merging?

Will do! 👍

@kclowes kclowes merged commit c296cae into ethereum:master Jun 16, 2022
@kclowes kclowes deleted the add-black-_utils-iii branch June 16, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants