Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More black linting #2622

Merged
merged 2 commits into from
Aug 25, 2022
Merged

More black linting #2622

merged 2 commits into from
Aug 25, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Aug 25, 2022

What was wrong?

I noticed that setup.py wasn't being linted, so added a CI check, and updated both bumpversion and the docs config to make sure they could find the correct version.

How was it fixed?

  • setup.py now gets linted in CI
  • Added double quotes to .bumpversion.cfg
  • Added double quotes to docs/conf.py

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes requested review from fselmo and pacrob August 25, 2022 20:22
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

err, except for failing test?

@kclowes
Copy link
Collaborator Author

kclowes commented Aug 25, 2022

I think it was just a rate limiting issue. Thanks for the re-run if that was you!

@kclowes kclowes merged commit 160cc70 into ethereum:master Aug 25, 2022
@kclowes kclowes deleted the more-black branch August 25, 2022 20:41
@ofek ofek mentioned this pull request Sep 4, 2022
pacrob pushed a commit to pacrob/web3.py that referenced this pull request Sep 8, 2022
* Add black linting to setup.py, have bumpversion search for the right thing

* Add newsfragment
pacrob pushed a commit that referenced this pull request Sep 8, 2022
* Add black linting to setup.py, have bumpversion search for the right thing

* Add newsfragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants