Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: address test timeouts #2638

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Chore: address test timeouts #2638

merged 1 commit into from
Sep 12, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Sep 8, 2022 •
edited
Loading

What was wrong?

  • We have inconsistent test timeouts that are leading to many failed test runs. Tests using unlock_account and unlock_account_dual_type pytest fixtures are a known source of timeout issues.

How was it fixed?

  • Split flaky tests, starting with unlocked_account and unlocked_account_dual_type fixture tests into their own test run / shorter CI job. It does seem to have many continuous successful runs.
  • Add some notes around integration test config so we don't start to clutter those conditionals and risk skipping some tests.

Todo:

Cute Animal Picture

20220908_143048

@fselmo fselmo force-pushed the wip-address-timeouts branch 10 times, most recently from 98bbf42 to ff6f908 Compare September 8, 2022 20:27
@fselmo fselmo marked this pull request as ready for review September 8, 2022 20:35
@fselmo fselmo changed the title WIP: try to address test timeouts Chore: address test timeouts Sep 8, 2022
@fselmo
Split flaky tests into their own CI run:
034c429 
- Split off tests that user ``unlock_account`` and ``unlock_account_dual_type`` pytest fixtures into their own CI run since they have been problematic for some time now and more recently are cousing timeouts again.
pacrob
pacrob approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kclowes
kclowes approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 !

@fselmo fselmo merged commit 7f372c4 into ethereum:master Sep 12, 2022
@fselmo fselmo deleted the wip-address-timeouts branch September 12, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fselmo @pacrob @kclowes