Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move flaky option to top level #2642

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Move flaky option to top level #2642

merged 2 commits into from
Sep 12, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Sep 12, 2022 •
edited
Loading

What was wrong?

Running pytest tests/ was throwing an AttributeError because there was no flaky on the top level.

How was it fixed?

Moved pytest_addoption from tests/integration/conftest.py to tests/conftest.py.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review September 12, 2022 18:36
@kclowes kclowes requested a review from fselmo September 12, 2022 18:36
fselmo
fselmo approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, lgtm! 👍🏼 Thanks!

@kclowes kclowes merged commit e54ce9e into ethereum:master Sep 12, 2022
@kclowes kclowes deleted the move-pytest-option branch September 12, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kclowes @fselmo