Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf #2666

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Update protobuf #2666

merged 1 commit into from
Oct 13, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Oct 5, 2022

What was wrong?

There is a DoS-able vulnerability in the protobuf dependency in versions less than v3.19.4. It was fixed in v3.19.5.

How was it fixed?

Pinned protobuf to 3.19.5.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review October 6, 2022 16:55
@kclowes kclowes force-pushed the update-protobuf branch 4 times, most recently from 4532b7d to a3513e3 Compare October 7, 2022 17:38
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 125fa64 into ethereum:master Oct 13, 2022
@kclowes kclowes deleted the update-protobuf branch October 13, 2022 15:20
@ofek ofek mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants