Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for geth 1.10.25 #2694

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Add support for geth 1.10.25 #2694

merged 3 commits into from
Oct 27, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Oct 26, 2022 •
edited
Loading

What was wrong?

py-geth just got released with Geth 1.10.25 support, so adding here too.

How was it fixed?

Bumped py-geth requirement and increased the geth version in circleci.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review October 26, 2022 21:02
@kclowes kclowes requested review from fselmo and pacrob October 26, 2022 21:02
fselmo
fselmo approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Should we generate the integration test fixture with the new geth version in this PR as well?

@kclowes
Copy link
Collaborator Author

kclowes commented Oct 27, 2022

Aha! I knew I was missing something! Thanks :)

@kclowes kclowes merged commit 7a8a0c9 into ethereum:master Oct 27, 2022
@kclowes kclowes deleted the update-geth-version branch October 27, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@pacrob pacrob Awaiting requested review from pacrob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kclowes @fselmo