Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SolidityError in favor of ContractLogicError #2697

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Remove SolidityError in favor of ContractLogicError #2697

merged 2 commits into from
Nov 2, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Oct 27, 2022 •
edited
Loading

What was wrong?

SolidityError wasn't an accurate name for the exception class. The better name is ContractLogicError.

Related to Issue #1901

How was it fixed?

Removed SolidityError in favor of ContractLogicError

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes requested review from fselmo and pacrob October 28, 2022 17:12
@kclowes kclowes marked this pull request as ready for review October 28, 2022 17:17
pacrob
pacrob approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit ef178cc into ethereum:master Nov 2, 2022
@kclowes kclowes deleted the remove-solidity-err branch November 2, 2022 16:41
@kclowes kclowes mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@fselmo fselmo Awaiting requested review from fselmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kclowes @pacrob