Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snakecase fromWeb3 #2703

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Snakecase fromWeb3 #2703

merged 4 commits into from
Nov 2, 2022

Conversation

linda-le1
Copy link
Contributor

@linda-le1 linda-le1 commented Nov 1, 2022

What was wrong?

Inherited javascript syntax. This PR does not include a deprecation step, intended for v6.
Related to Issue #2598

How was it fixed?

Changed fromWeb3 to from_web3 where needed

Todo:

Cute Animal Picture

cute-red-panda

@linda-le1 linda-le1 marked this pull request as ready for review November 1, 2022 03:40
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 I left one small nitpick, but looks good otherwise!

web3/main.py Outdated Show resolved Hide resolved
@kclowes kclowes merged commit 81c2088 into ethereum:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants