-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special case for Nethermind\Gnosis revert errors #2739
Conversation
Of the form: 'Reverted 0x4f776e6572496420646f6573206e6f7420657869737420696e207265676973747279'
Thanks for this! Do you mind adding a test for this case in this file? I think we should also add a newsfragment, but I'm happy to do that if you don't want to. I can also fix the lint errors too, just let me know. |
Will do! |
sounds good, thanks! eventually we'll have autoformatting on commit, but it hasn't reached the top of our priority queue yet. |
Having some trouble running the tests locally, hope you don't mind me using your circleci to verify correctness! |
Tests look fine! I'd be grateful if you could fix the linter error, it seems to survive a pass of Black Formatter and it's actually pre-existing code Likewise with the newsfragment. Thanks for the prompt responses, and looking forward to seeing this merged |
Yep, no problem! Thanks again! |
What was wrong?
Certain forms of errors, eg. generated on Spaceneth\Nethermind setups, would fail to return revert reasons on contracts.
Of the form: 'Reverted 0x4f776e6572496420646f6573206e6f7420657869737420696e207265676973747279'
How was it fixed?
A small edge case handling was added in the error_formatting.
Todo:
This doesn't really seem worth mentioning in release notes. Let me know if that's wanted.
Cute Animal Picture