Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support latest tox v4 #2751

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Support latest tox v4 #2751

merged 2 commits into from
Dec 8, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Dec 7, 2022 •
edited
Loading

What was wrong?

A tox upgrade broke our lint CI runs.

How was it fixed?

Added an upper pin to the tox install in our CI config

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the fix-windows-build branch 6 times, most recently from c2c41a2 to 65aca78 Compare December 7, 2022 21:49
@kclowes kclowes changed the title whitelist bash.exe Remove deprecated whitelist in favor of allowlist in tox.ini Dec 7, 2022
@kclowes kclowes force-pushed the fix-windows-build branch 2 times, most recently from d474819 to 934eaa9 Compare December 7, 2022 23:01
@kclowes kclowes marked this pull request as ready for review December 7, 2022 23:12
@kclowes kclowes mentioned this pull request Dec 7, 2022
Merged
1 task
@kclowes kclowes changed the title Remove deprecated whitelist in favor of allowlist in tox.ini Pin tox to <4.0 Dec 7, 2022
@kclowes kclowes requested review from fselmo and pacrob December 7, 2022 23:15
pacrob
pacrob approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

fselmo
fselmo approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just left one nit that might help us track down the different places where we may need to update tox. [outdated]

.circleci/config.yml Outdated Show resolved Hide resolved
@kclowes kclowes force-pushed the fix-windows-build branch 3 times, most recently from 596e2ec to c687697 Compare December 8, 2022 18:49
@kclowes kclowes changed the title Pin tox to <4.0 Support latest tox v4 Dec 8, 2022
fselmo
fselmo approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this route! Consider this re-approved 🚀 ... just needs the newsfragment message updated

@kclowes
Copy link
Collaborator Author

kclowes commented Dec 8, 2022

You're so fast! Thanks!

@kclowes kclowes merged commit 6fd84b8 into ethereum:master Dec 8, 2022
@kclowes kclowes deleted the fix-windows-build branch December 8, 2022 20:26
@wolovim wolovim mentioned this pull request Dec 12, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@pacrob pacrob pacrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kclowes @fselmo @pacrob