-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V6 migration #2778
V6 migration #2778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found some minor tweaks. Are we trying to leave this branch open, add to it, and only merge when it's finalized?
I was thinking we'd get it in now-ish and then add to it as breaking changes come up, but open to either if you have a strong opinion. |
No strong opinion here, just seeing that it was still a draft but had a review request haha. I think the fact we're in beta is good enough to merge this and keep adding to it as the PRs come in. I think I'd even prefer merging this in since that gives users more time to make the changes that are already on here. |
Same! Updated! Lmk if there are changes that should be made to clarify the ValidationError section. That one was sort of tricky to describe. |
I think this looks good for a migration guide description. We can go a bit more in depth with the actual documentation on it once that comes along. (see: #2779) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, good to get in now for better visibility
What was wrong?
We need a v6 migration guide!
How was it fixed?
Added one!
Todo:
Cute Animal Picture