Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 migration #2778

Merged
merged 4 commits into from
Jan 18, 2023
Merged

V6 migration #2778

merged 4 commits into from
Jan 18, 2023

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jan 13, 2023

What was wrong?

We need a v6 migration guide!

How was it fixed?

Added one!

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found some minor tweaks. Are we trying to leave this branch open, add to it, and only merge when it's finalized?

docs/v6_migration.rst Outdated Show resolved Hide resolved
docs/v6_migration.rst Outdated Show resolved Hide resolved
docs/v6_migration.rst Outdated Show resolved Hide resolved
@kclowes
Copy link
Collaborator Author

kclowes commented Jan 13, 2023

Are we trying to leave this branch open, add to it, and only merge when it's finalized?

I was thinking we'd get it in now-ish and then add to it as breaking changes come up, but open to either if you have a strong opinion.

@fselmo
Copy link
Collaborator

fselmo commented Jan 13, 2023

I was thinking we'd get it in now-ish and then add to it as breaking changes come up, but open to either if you have a strong opinion.

No strong opinion here, just seeing that it was still a draft but had a review request haha. I think the fact we're in beta is good enough to merge this and keep adding to it as the PRs come in. I think I'd even prefer merging this in since that gives users more time to make the changes that are already on here.

@kclowes kclowes marked this pull request as ready for review January 13, 2023 21:13
@kclowes
Copy link
Collaborator Author

kclowes commented Jan 13, 2023

I think I'd even prefer merging this in since that gives users more time to make the changes that are already on here.

Same! Updated! Lmk if there are changes that should be made to clarify the ValidationError section. That one was sort of tricky to describe.

@fselmo
Copy link
Collaborator

fselmo commented Jan 13, 2023

Lmk if there are changes that should be made to clarify the ValidationError section

I think this looks good for a migration guide description. We can go a bit more in depth with the actual documentation on it once that comes along. (see: #2779)

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good to get in now for better visibility

@kclowes kclowes merged commit be69b50 into ethereum:master Jan 18, 2023
@kclowes kclowes deleted the v6-migration branch January 18, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants