Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async eth.get_uncle_count #2822

Closed
kclowes opened this issue Feb 17, 2023 · 3 comments
Closed

Add async eth.get_uncle_count #2822

kclowes opened this issue Feb 17, 2023 · 3 comments

Comments

@kclowes
Copy link
Collaborator

kclowes commented Feb 17, 2023

What was wrong?

Some methods are still unavailable on the AsyncEth class.

How can it be fixed?

Following the pattern already established, add get_uncle_count to the AsyncEth class, and add corresponding tests.

@konichuvak
Copy link
Contributor

Would be happy to help with these.

I assume that the tests should be added here.
If that is the case, could you please comment on how to run the tests for AcyncEthModuleTest?
Since there is no conftest in any of the modules along the path to the test class, pytest does recognize it as a valid test target.

I see that for EthModuleTest we use TestEthereumTesterEthModule, individual tests for which could be ran with a command like

pytest tests/integration/test_ethereum_tester.py -k "test_eth_getBlockByNumber_finalized"

@kclowes
Copy link
Collaborator Author

kclowes commented Feb 22, 2023

Awesome, thank you!

I assume that the tests should be added here.

Yep, tests should be added in that file.

If that is the case, could you please comment on how to run the tests for AcyncEthModuleTest?

You should be able to pretty much copy/paste the sync tests and add asyncs and awaits where needed. To run the tests locally against Geth, you can run pytest tests/integration/go_ethereum/test_goethereum_http.py or to run against eth-tester you can run pytest tests/integration/test_ethereum_tester.py. And like you mentioned, you can pass the -k flag to single out test(s). Or, to run all of the tests in the AsyncEth module, you can do: pytest tests/integration/go_ethereum/test_goethereum_http.py::TestGoEthereumAsyncEthModuleTest. Let me know if you have any other questions!

Thanks for the help!

@kclowes
Copy link
Collaborator Author

kclowes commented Apr 14, 2023

Closed via #2850

@kclowes kclowes closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants