Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async eth.modify_transaction #2825

Closed
kclowes opened this issue Feb 17, 2023 · 3 comments
Closed

Add async eth.modify_transaction #2825

kclowes opened this issue Feb 17, 2023 · 3 comments

Comments

@kclowes
Copy link
Collaborator

kclowes commented Feb 17, 2023

What was wrong?

Some methods are still unavailable on the AsyncEth class.

How can it be fixed?

Following the pattern already established, add modify_transaction to the AsyncEth class, and add corresponding tests. The AsyncHTTPProvider docs in docs/provider.rst will also need to be updated.

@ketan3108
Copy link

Hey @kclowes ,I am interested in contributing. Can you guide me by providing some references ?

@esing1201
Copy link

Hi @kclowes I am happy to claim this issue!

@kclowes
Copy link
Collaborator Author

kclowes commented Apr 10, 2023

Thanks @esing1201! Here is the most recent example of a new async function that's been merged: #2848. The replace_transaction PR might also be helpful: #2847.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants