Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async eth.sign_transaction #2827

Closed
kclowes opened this issue Feb 17, 2023 · 5 comments · Fixed by #2848
Closed

Add async eth.sign_transaction #2827

kclowes opened this issue Feb 17, 2023 · 5 comments · Fixed by #2848
Labels
Good First Issue

Comments

@kclowes
Copy link
Collaborator

kclowes commented Feb 17, 2023

What was wrong?

Some methods are still unavailable on the AsyncEth class.

How can it be fixed?

Following the pattern already established, add sign_transaction to the AsyncEth class, and add corresponding tests. The AsyncHTTPProvider docs in docs/provider.rst will also need to be updated.
@Player256
Copy link
Contributor

@kclowes I am interested in contributing. Can you guide me by providing some references?

@kclowes
Copy link
Collaborator Author

kclowes commented Feb 23, 2023

Sure, thanks! #2833 is a good example. Basically, copy/paste the existing sync send_transaction tests and add async/await where needed, and then add the method in the AsyncEth class. Let me know if you have other questions! Or feel free to put up a PR and one of us will help review.

@Player256 Player256 mentioned this issue Feb 24, 2023
Merged
1 task
@Player256
Copy link
Contributor

Hey, @kclowes can you guide me through the pr that I have made?

@sujantkumarkv
Copy link

Hey!
I request update on this issue and the pull #2848. Is it/Will be done? Or it needs help?
Thanks.

@kclowes @Player256

@Player256
Copy link
Contributor

Can you help me through this pr?@sujantkumarkv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add async eth.sign_transaction Player256/web3.py
3 participants
@kclowes @sujantkumarkv @Player256